-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded MudBlazor Templates to .NET 9 #482
base: dev
Are you sure you want to change the base?
Conversation
{ | ||
"condition": "(!IndividualLocalAuth)", | ||
"exclude": [ | ||
"**/wwwroot/bootstrap/**" | ||
] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines ensure that bootstrap isn't included in MudBlazor templates. However, we removed this folder in PR #465 and it won't appear again unless we start templates completely from scratch in the future.
@@ -130,7 +124,6 @@ | |||
"exclude": [ | |||
"MudBlazor.Template/Components/Account/**", | |||
"MudBlazor.Template/Data/**", | |||
"MudBlazor.Template.Client/PersistentAuthenticationStateProvider.cs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provider is no longer necessary as of .NET 9.
"condition": "(!(IndividualLocalAuth && UseServer && UseWebAssembly))", | ||
"exclude": [ | ||
"MudBlazor.Template/Components/Account/PersistingRevalidatingAuthenticationStateProvider.cs" | ||
] | ||
}, | ||
{ | ||
"condition": "(!(IndividualLocalAuth && UseServer && !UseWebAssembly))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provider has been completely removed in .NET 9.
@@ -2,6 +2,6 @@ | |||
<PageTitle>Reset password confirmation</PageTitle> | |||
|
|||
<h1>Reset password confirmation</h1> | |||
<p> | |||
Your password has been reset. Please <a class="mud-link mud-primary-text mud-link-underline-hover" href="Account/Login">click here to log in</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, these CSS classes shouldn't have been deleted. I'll restore them.
@@ -1,3 +1,3 @@ | |||
@using MudBlazor | |||
@using MudBlazor.Template.Components.Account.Shared | |||
@layout AccountLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, the entire AccountLayout.razor
was deleted in the latest templates, and MainLayout.razor
is used instead.
Was a little mistake to give the main branch instead of the tag 9.0, it seems the main is on two commits a head, but luckily it seems only the tempalate.json is different with the net.10, so here is the correct one for .net9. |
The rest seems to be the same |
You're totally right! That's a relief that only the template is different; I will get that sync'ed today then. |
I added net9 to the build system, feel free to update the branch |
…h. Will finish testing tonight.
Somehow it still fails to build in CI, tho it's fine locally via the nuke-build. Not sure why it still thinks net8 is installed. I will look at it tmr, too tired for it today. |
Quality Gate passedIssues Measures |
Ok, I've finished testing all template projects and have verified that the new auth in .NET 9 is working as expected. I've restored the original Welcome message, and I think we're in good shape to review! |
Description
Resolves: #481
This update upgrades MudBlazor templates to match the latest ASP.NET Core Blazor Project templates. Changes include a reduced amount of code for auth pages, a better way to detect render modes, and an upgrade to .NET 9. Overall, however, files are largely the same.
Changes were made by performing the following steps:
MudBlazor.Templates
repo (clone link)aspnetcore
repo (clone link)net9
branch inaspnetcore
aspnetcore\src\ProjectTemplates\Web.ProjectTemplates\content\BlazorWeb-CSharp\BlazorWeb-CSharp
in BeyondCompare and setting the local code folders via Set Base FoldersSpecial thanks once again to @Anu6is for the MudBlazor.Static library for the Account Management pages.
Using BeyondCompare to Update Templates
How Has This Been Tested?
This was tested by:
.\InstallAndBuildAllTemplates.ps1
PowerShell scriptType of Changes
Checklist
dev
).